Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TBS: change default disk usage threshold to 0.8 #15524

Merged
merged 4 commits into from
Feb 3, 2025
Merged

TBS: change default disk usage threshold to 0.8 #15524

merged 4 commits into from
Feb 3, 2025
+7 −6

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Feb 3, 2025 •
edited
Loading

Motivation/summary

Change TBS default usage threshold to 0.8 for a lower risk. Change log to be slightly more readable.

With this change, the log looks like

setting disk usage threshold to 80% of total disk space of 912.7gb

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Check logs setting disk usage threshold ... when storage_limit is set to 0.

Related issues

Changing the default set in #15467

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 3, 2025

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-9./d is the label to automatically backport to the 9./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

@carsonip carsonip marked this pull request as ready for review February 3, 2025 13:51
@carsonip carsonip requested a review from a team as a code owner February 3, 2025 13:51
@carsonip carsonip requested a review from simitt February 3, 2025 14:34
@carsonip carsonip added the backport-9.0 Automated backport to the 9.0 branch label Feb 3, 2025
@carsonip carsonip enabled auto-merge (squash) February 3, 2025 14:39
@carsonip carsonip merged commit 9ccfae6 into elastic:main Feb 3, 2025
15 of 16 checks passed
mergify bot pushed a commit that referenced this pull request Feb 3, 2025
@carsonip @mergify
TBS: change default disk usage threshold to 0.8 (#15524)
495d16a 
Change TBS default usage threshold to 0.8 for a lower risk. Change log to be slightly more readable.

(cherry picked from commit 9ccfae6)

# Conflicts:
#	changelogs/9.0.asciidoc
@mergify mergify bot mentioned this pull request Feb 3, 2025
Merged
2 tasks
mergify bot added a commit that referenced this pull request Feb 3, 2025
@mergify @carsonip
[9.0] TBS: change default disk usage threshold to 0.8 (backport #15524)…
fadcc78 
… (#15525)

* TBS: change default disk usage threshold to 0.8 (#15524)

Change TBS default usage threshold to 0.8 for a lower risk. Change log to be slightly more readable.

(cherry picked from commit 9ccfae6)

# Conflicts:
#	changelogs/9.0.asciidoc

* Fix conflict

---------

Co-authored-by: Carson Ip <[email protected]>
Co-authored-by: Carson Ip <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simitt simitt simitt approved these changes

Assignees
No one assigned
Labels
backport-9.0 Automated backport to the 9.0 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carsonip @simitt